Bug fix for pull request #2 #3
Conversation
| def update_line(self, current): | ||
| num_bar = int(current / 100.0 * (self._term_width - 5)) | ||
| return '#' * num_bar + ' ' * (self._term_width - 5 - num_bar) + \ | ||
| u' %3d' % int(current) + u'%\r' |
There was a problem hiding this comment.
Please don't break the like here, screens are wide enough nowadays :-)
There was a problem hiding this comment.
I think this is not so bad, it's because PEP8 said that limit all lines to a maximum of 79 characters.
http://www.python.org/dev/peps/pep-0008/#maximum-line-length
But, if you don't like above, i'll modify it like this.
def update_line(self, current):
num_bar = int(current / 100.0 * (self._term_width - 5))
bars = u'#' * num_bar
spaces = u' ' * (self._term_width - 5 - num_bar)
percentage = u'%3d' % int(current) + u'%\r'
return bars + spaces + u' ' + percentage
|
Hi, Thanks! The diff looks fine, I just added some minor comments. Actually I'm thinking about removing the |
|
OK, I fixed them. Please check them.
Nice! |
|
Done! I just merged your changes and then removed Curl :-) Thanks a lot! |
Bug fix for #2 Add genericdownloader as substitute of curl module.
Though I want to use fetch command via popen, it can't use HEAD method, so I write genericdownloader module. This module consists of urllib and httplib and behaves like curl module.
I check these changes in FreeBSD and MacOSX and they work well ;)